update environment.json to get the data from live cy instance#160
Merged
FloSch62 merged 3 commits intosrl-labs:mainfrom Jun 19, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The topology
prefixhandling was previously inconsistent. And this impacting theedgeSharkhandling from TopoViewer.Fix Strategy:
Update the
environment.jsonfile by enriching itsEnvCyTopoJsonBytesfield using live topology data from the active Cytoscape (cy) instance. This enrichment process correctly computes the prefix using production-grade logic and ensures that each edge contains accurateclabSourceLongNameandclabTargetLongNamevalues. The prefix logic now safely handles invalid or missing values, avoiding unintended"null"strings.ausfügrung-01:
edgeSharkhandler reads link data from the updatedenvironment.json. Since this file is refreshed usingcy.elements().jsons()enriched by the prefix-aware logic, it reflects the correct topology state. This ensures that all node and edge names — including those with optional prefixes — are consistent and valid for downstream processing.CleanShot.2025-06-17.at.23.03.20.mp4